reviewing-a-pull-request
Differences
This shows you the differences between two versions of the page.
| Both sides previous revisionPrevious revision | |||
| reviewing-a-pull-request [2023/12/19 14:39] – Roman Sheydvasser | reviewing-a-pull-request [2024/09/09 18:04] (current) – Roman Sheydvasser | ||
|---|---|---|---|
| Line 18: | Line 18: | ||
| - If there aren’t automated tests, confirm that the PR description contains at least 1-2 items describing how the changes were tested. | - If there aren’t automated tests, confirm that the PR description contains at least 1-2 items describing how the changes were tested. | ||
| - Check each changed file for potential bugs that the submitter may have missed. | - Check each changed file for potential bugs that the submitter may have missed. | ||
| - | - Check to see if [[https:// | + | - Check to see if [[https:// |
| - Check for typos in the comments and readmes. | - Check for typos in the comments and readmes. | ||
| - If you’re not proficient with the programming language or framework used, make a note of that in your review. | - If you’re not proficient with the programming language or framework used, make a note of that in your review. | ||
reviewing-a-pull-request.1702996764.txt.gz · Last modified: 2023/12/19 14:39 by Roman Sheydvasser